Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit alias_name_source explanation #27382

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Edit alias_name_source explanation #27382

merged 4 commits into from
Aug 7, 2024

Conversation

mladlow
Copy link
Contributor

@mladlow mladlow commented Jun 6, 2024

We wanted to clarify the difference between the two options and the implications.

Screenshot 2024-06-21 at 16 16 01

I've attached a screenshot because Vercel failed. It seems to look ok. The preview is missing one set of backticks which I've added in a new commit.

We wanted to clarify the difference between the two options and the implications.
@mladlow mladlow requested a review from a team as a code owner June 6, 2024 14:25
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jun 6, 2024

Build Results:
All builds succeeded! ✅

@mladlow
Copy link
Contributor Author

mladlow commented Jul 9, 2024

@schavis could you take another look at this please?

@schavis
Copy link
Contributor

schavis commented Aug 6, 2024

Apologies, I've been a bit underwater. Feel free to merge!

@schavis schavis merged commit fd1e53d into main Aug 7, 2024
32 checks passed
@schavis schavis deleted the docs/k8s-alias-name-source branch August 7, 2024 23:07
Monkeychip pushed a commit that referenced this pull request Aug 9, 2024
* Edit alias_name_source explanation

We wanted to clarify the difference between the two options and the implications.

* Add missing backticks

* Add comma

* Update website/content/api-docs/auth/kubernetes.mdx

Co-authored-by: Sarah Chavis <[email protected]>

---------

Co-authored-by: Sarah Chavis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants